-
Notifications
You must be signed in to change notification settings - Fork 159
[eppp]: Support for transport via Ethernet (phy or emac) #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eppp]: Support for transport via Ethernet (phy or emac) #622
Conversation
150f1b3
to
001855e
Compare
001855e
to
da05de2
Compare
@kostaond Thanks taking a look at the emac2emac option. I must say that I concur with your assessment and think that this option is probably not a viable transport option for My suggestion is that we drop the emac2emac option in this PR, but allow the Ethernet init/start functionality to be extended (with callbacks or |
Agree, if you need to move forward, drop the emac2emac. It's currently too much polluted with the GPIO0 workaround. Presence or non presence of the workaround must be super clear to users because the most probable use case is to use ESP32 with WiFi connected to some other chip without WiFi. |
da05de2
to
35f9579
Compare
Removed the emac2emac from the component and added it as an extra example with the specific configuration, so the GPIO0 workaround is in the app code only. (Moreover It demonstrates using any custom Ethernet driver) |
e03a0cd
to
de4af56
Compare
@kostaond @euripedesrocha Thanks for your review, I've reworked this PR, so that it uses "just Ethernet" with customizable initialization. Then (in a separate commit) I've added the EMAC-2-EMAC example with all those workarounds and magic delays. |
de4af56
to
1d6328d
Compare
772c84b
to
b00d44c
Compare
b00d44c
to
a21ce88
Compare
Thanks for your review, Ondrej & Euripedes! |
Using a dummy phy, by means of EMAC to EMAC connectionAdded emac2emac example which demonstrates overriding (standard) Ethernet drivers with the custom one: eth_dummy_phy